perf: optimize encode in datafusion-functions#23456
Merged
Dandandan merged 1 commit intoJul 11, 2026
Merged
Conversation
Jefffrey
approved these changes
Jul 11, 2026
| // The slice is sized to exactly `2 * v.len()`, which is the only | ||
| // condition under which `encode_to_slice` can fail, so this cannot | ||
| // error. | ||
| hex::encode_to_slice(v, &mut values[pos..pos + out_len]) |
Contributor
There was a problem hiding this comment.
i remember we did some work previously on having a faster hex encoding algorithm (iirc for Spark functions)
would that be applicable here too?
Member
Author
There was a problem hiding this comment.
That's a good point. I opened I opened #23473 to apply this pattern there to apply some of the same optimizations for Spark hex encoding.
Dandandan
approved these changes
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Rewrote the hex path of encode() to write hex directly into one pre-sized buffer via hex::encode_to_slice, eliminating a per-element String allocation and copy per row.
What changes are included in this PR?
Rewrote the hex path of encode() to write hex directly into one pre-sized buffer via hex::encode_to_slice, eliminating a per-element String allocation and copy per row.
Are these changes tested?
Existing tests
Benchmark:
Are there any user-facing changes?
No